Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update to Apache Lucene 10 for 3.0.0 #16366

Draft
wants to merge 81 commits into
base: main
Choose a base branch
from

Conversation

reta
Copy link
Collaborator

@reta reta commented Oct 17, 2024

Description

Update to Apache Lucene 10 for 3.0.0

Related Issues

Closes #11415

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added dependencies Pull requests that update a dependency file enhancement Enhancement or improvement to existing feature or request v3.0.0 Issues and PRs related to version 3.0.0 labels Oct 17, 2024
@reta
Copy link
Collaborator Author

reta commented Oct 17, 2024

@msfroh @mch2 @dblock @andrross opening the early draft pull request for collective effort, please feel free to push changes into this branch.

Copy link
Contributor

❌ Gradle check result for 76a5268: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 41d7448: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for df71508: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 77dcc97: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 19a8ca4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 2b75ea1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 44df041: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 365a624: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for ceb2b99: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Nov 1, 2024

❌ Gradle check result for 61f4a3a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Nov 1, 2024

❌ Gradle check result for e6c7f59: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Nov 1, 2024

❌ Gradle check result for 0cfa7c8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for b780ac5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

I'm not really fixing the failing tests, but ensuring that the two
tests that fail don't cause a bunch of other tests to fail by
leaving transient settings around. (Clean up the transient settings
even if those tests fail.)

Signed-off-by: Michael Froh <[email protected]>
I broke these when fixing DerivedFieldMapperQueryTests.

Signed-off-by: Michael Froh <[email protected]>
Copy link
Contributor

❌ Gradle check result for ea0549b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Needed to update mocked calls.

Signed-off-by: Michael Froh <[email protected]>
Copy link
Contributor

❌ Gradle check result for 3d0b52d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 17ecd4c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 17ecd4c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

expani and others added 3 commits December 19, 2024 15:13
Fixed tests depending on Lucene 7.x Index to start using Lucene 8.x index ( OS 1.3 )
Copy link
Contributor

❌ Gradle check result for 0874389: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 3549c2d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

expani and others added 2 commits December 20, 2024 17:25
Copy link
Contributor

❌ Gradle check result for 5871134: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 2c35bfc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 72cff6d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@expani
Copy link
Contributor

expani commented Dec 23, 2024

Currently working on

ContextIndexSearcherTests > testContextIndexSearcherSparseNoDeletions FAILED
ContextIndexSearcherTests > testIntersectScorerAndRoleBits FAILED
ContextIndexSearcherTests > testContextIndexSearcherSparseWithDeletions FAILED

Also, have a fix ready for CategoryContextMappingTests

expani and others added 3 commits December 23, 2024 15:33
…ss modified check in lucene Field

Signed-off-by: expani <[email protected]>
Fixed CategoryContextMappingTests and ContextIndexSearcherTests
Copy link
Contributor

❌ Gradle check result for a74e65e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for a74e65e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement Enhancement or improvement to existing feature or request v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Update to Apache Lucene 10 for 3.0.0
5 participants